Skip to content

Conversation

michalpelka
Copy link
Collaborator

@michalpelka michalpelka commented Oct 7, 2025

What does this PR do?

Publish joint state.
Documentation on using c++ arrays in Lua.

How was this PR tested?

Run in project that need this tool


Screenshots / Logs / Supporting Evidence (if applicable)

nada


Committer Checklist

Please confirm the following before marking this PR as ready for review:

  • Code changes are well-documented
  • Tests have been added or updated
  • The code is formatted according to the project's style guide
  • The version number has been updated according to the contributing guidelines

@michalpelka michalpelka changed the base branch from o3de-2505 to o3de-2510 October 7, 2025 15:05
@michalpelka michalpelka force-pushed the mp/publish_joint_state branch from b88b11f to 8209317 Compare October 7, 2025 15:08
@michalpelka michalpelka requested a review from knicked October 7, 2025 15:09
Signed-off-by: Michał Pełka <[email protected]>
Copy link

@knicked knicked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code, LGTM

Copy link
Collaborator

@jhanca-robotecai jhanca-robotecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected in Lua. Please fix the issue for ScriptCanvas. Please bump version of the Gem to 2.1.0

{ "Acceleration", "" },
{ "Jerk", "" } } });
{ "Jerk", "" } } })
->Event("PublishJointStateMsg", &PublisherRequestBus::Events::PublishJointStateMsg);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listing parameters with names makes the component usable in ScriptCanvas - could you please add it? See the comparison below:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants